fix: RangePicker missing arrow and RTL styles #49333

afc163 · 2024-06-10T08:28:15Z

🤔 This is a ...

🔗 Related issue link

close RangePicker. 'ant-picker-range-arrow' not shown when passing prop 'placement=bottomRight' #47699
close DatePicker TimePicker 的 RangePicker 在 placement 设置为 topRight 或 bottomRight 时箭头丢失 #34501
close DayPicker control - Month and year switching buttons are not accessible via keyboard and have no aria-labels #32513
close Ensures buttons have discernible text. #45057
close DatePiker.RangePicker 使用年份时，先输入结束年份会报错 #49400
close RangePicker resetting selected date on keyboard input #49057

💡 Background and solution

See full diff: react-component/picker@v4.5.0...v4.6.4

此处可以测试箭头和 rtl 的效果：https://preview-49333-ant-design.surge.sh/components/date-picker-cn#components-date-picker-demo-placement

📝 Changelog

Language	Changelog
🇺🇸 English	- Fix DatePicker.RangePicker/TimePicker.RangePicker's arrow is missing when `placement` is set to `topRight` or `bottomRight`. - Address DatePicker accessibility issue with the toggle button lacking alternative text. - Fix DatePicker.RangePicker broken style in rtl mode. - Fix DatePicker.RangePicker `picker="year"` throws error when input end value first. - 🇹🇷 Improve DatePicker tr_TR locales. - Fix DatePicker.RangePicker resetting selected date on keyboard input.
🇨🇳 Chinese	- 修复 DatePicker/TimePicker 的 RangePicker 在 `placement` 设置为 `topRight` 或 `bottomRight` 时箭头丢失的问题。 - 修复 DatePicker 切换按钮缺失可访问性文本的问题。 - 修复 DatePicker.RangePicker 在 RTL 模式下的样式问题。 - 修复 DatePicker.RangePicker 年选择器先输入结束值会导致报错的问题。 - 🇹🇷 调整 DatePicker 的土耳其语言文案。 - 修复 DatePicker.RangePicker 键盘输入日期时已选日期重置的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

stackblitz · 2024-06-10T08:28:19Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2024-06-10T08:28:26Z

👁 Visual Regression Report for PR #49333 Passed ✅

🎯 Target branch: feature (9c91bdb)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

github-actions · 2024-06-10T08:28:29Z

github-actions · 2024-06-10T08:31:25Z

size-limit report 📦

Path	Size
`./dist/antd.min.js`	340.38 KB (-58 B 🔽)
`./dist/antd-with-locales.min.js`	389.5 KB (+2 B 🔺)

socket-security · 2024-06-10T08:41:29Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/rc-picker@4.6.4-0	None	`0`	0 B

🚮 Removed packages: npm/rc-picker@4.5.0

View full report↗︎

afc163 · 2024-06-11T06:58:24Z

箭头位置还有问题。

package.json

Signed-off-by: afc163 <afc163@gmail.com>

socket-security · 2024-06-11T07:31:21Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/rc-picker@4.6.4-0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

package.json

Signed-off-by: afc163 <afc163@gmail.com>

package.json

Signed-off-by: afc163 <afc163@gmail.com>

codecov · 2024-06-11T15:28:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (9c91bdb) to head (3e3f98e).

Additional details and impacted files

@@           Coverage Diff            @@
##           feature   #49333   +/-   ##
========================================
  Coverage    99.99%   99.99%           
========================================
  Files          750      750           
  Lines        13132    13132           
  Branches      3443     3443           
========================================
  Hits         13131    13131           
  Misses           1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json

Signed-off-by: afc163 <afc163@gmail.com>

afc163 · 2024-06-18T06:28:07Z

@SocketSecurity ignore-all

package.json

Signed-off-by: afc163 <afc163@gmail.com>

package.json

Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com> Signed-off-by: afc163 <afc163@gmail.com>

* bump rc-picker * chore: update snapshot * chore: update snapshot * fix: arrow style * fix: arrow transition style * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * fix: rtl style * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * fix rtl style * chore: update snapshot * fix rtl style * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com> Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: afc163 <afc163@gmail.com> Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com>

C3maLi · 2024-07-18T16:31:11Z

@afc163
Following the implementation of this PR, the Turkish date formats are not displaying correctly.
For further details, please see the related issue: #49956

* bump rc-picker * chore: update snapshot * chore: update snapshot * fix: arrow style * fix: arrow transition style * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * fix: rtl style * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * fix rtl style * chore: update snapshot * fix rtl style * Update package.json Signed-off-by: afc163 <afc163@gmail.com> * Update package.json Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com> Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: afc163 <afc163@gmail.com> Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com>

bump rc-picker

2f32073

afc163 changed the title ~~bump rc-picker~~ fix: RangePicker missing arrow Jun 10, 2024

afc163 marked this pull request as ready for review June 10, 2024 08:34

chore: update snapshot

9ba4bbb

chore: update snapshot

14be468

li-jia-nan previously approved these changes Jun 11, 2024

View reviewed changes

afc163 marked this pull request as draft June 11, 2024 01:31

afc163 added 2 commits June 11, 2024 13:46

Merge branch 'feature' into fix/date-picker-bugs

97802b2

fix: arrow style

97745d2

afc163 dismissed li-jia-nan’s stale review via 97745d2 June 11, 2024 06:32

fix: arrow transition style

eaf6bae

afc163 force-pushed the fix/date-picker-bugs branch from 4c34bb8 to eaf6bae Compare June 11, 2024 07:01

afc163 mentioned this pull request Jun 11, 2024

fix: arrow position when placement is right react-component/picker#822

Merged

afc163 commented Jun 11, 2024

View reviewed changes