JavaScript target cannot use rule exceptions

[ChristophWedler]

The try block around the rule body is not properly closed by } when using rule exceptions:

grammar noRuleExceptions;
options { language = JavaScript; }

start
    :
        'start'
    ;
    catch [re] {
        throw re;
    }

In antlr4/tool/resources/org/antlr/v4/tool/templates/codegen/JavaScript/JavaScript.stg,
the } must move from after to before the following block (starting in line 269),
as it is done for the Java target:

    <if(exceptions)>
    <exceptions; separator="\n">
    <else>

[ericvergnaud]

Hi, thanks for this. can you submit a PR so we can understand how this would behave? Eric

…

Le 9 mars 2017 à 19:58, ChristophWedler ***@***.***> a écrit : The try block around the rule body is not properly closed by } when using rule exceptions: grammar noRuleExceptions; options { language = JavaScript; } start : 'start' ; catch [re] { throw re; } In antlr4/tool/resources/org/antlr/v4/tool/templates/codegen/JavaScript/JavaScript.stg, the } must move from after to before the following block (starting in line 269), as it is done for the Java target: <if(exceptions)> <exceptions; separator="\n"> <else> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1741>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADLYJGDmVkGBruywdSMU0arEisLi_NyWks5rj-lwgaJpZM4MX_dX>.

[ChristophWedler]

I have understood that I also need to sign contributors.txt - still need some days to get an official OK from the company I work at.

[ericvergnaud]

Closing as already fixed