Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for 4.9.3 release #3301

Closed
parrt opened this issue Oct 11, 2021 · 68 comments
Closed

Preparing for 4.9.3 release #3301

parrt opened this issue Oct 11, 2021 · 68 comments
Milestone

Comments

@parrt
Copy link
Member

parrt commented Oct 11, 2021

It's that time of year again! @pboyer, @mike-lischke, @janyou, @ewanmellor, @hanjoes, @ericvergnaud, @lingyv-li, @marcospassos Shall we do a 4.9.3 release?

I went through and marked all of the merged PRs and related issues with 4.9.3 and try to tag them according to their target. Would you guys like to go through the PRs to see if there's something that should be merged quickly?

@parrt parrt added this to the 4.9.3 milestone Oct 11, 2021
@KvanTTT
Copy link
Member

KvanTTT commented Oct 11, 2021

This one can be merged: #3211

@parrt
Copy link
Member Author

parrt commented Oct 11, 2021

Thanks, @KvanTTT I was just going to add you to this participant list...merged.

@hanjoes
Copy link
Member

hanjoes commented Oct 11, 2021

here is a list of PRs related, not sure if i'm missing out anything: https://github.com/antlr/antlr4/pulls?q=is%3Apr+is%3Aopen+swift
#3025 #3026 #3098 #3099 seem fine to be merged
#3132 is related to #1771 where you folks seem to have had a massive discussion .. will need to take a look later in the day.

@parrt
Copy link
Member Author

parrt commented Oct 11, 2021

Ok, I merged all those except #3132. thanks!

@lingyv-li
Copy link
Member

yay!
#3119 #3245 #3246 #3247 #3253 should be ready to be merged.
#3191 can be closed (without merging) as it's achieved by #3250

@ericvergnaud
Copy link
Contributor

All good here, nothing to merge for C#, Javascript, Python2 or Python3

@mike-lischke
Copy link
Member

mike-lischke commented Oct 12, 2021

I have nothing (to my knowledge) that would need to be merged yet for this release (regarding the C++ target).

btw. would it be possible to notify target owners when an issue or PR is posted and tagged with a language? Or some other kind of notification?

@parrt
Copy link
Member Author

parrt commented Oct 14, 2021

@mike-lischke I try to add the target label as I merge PRs and close bugs.

@lingyv-li ok, I have merged all of those you mentioned!

thanks guys!

@parrt
Copy link
Member Author

parrt commented Oct 14, 2021

@hanjoes it looks like the swift target is failing. can you take a look at the error message? https://github.com/antlr/antlr4/runs/3863274808?check_suite_focus=true

Actually Swift just ran through all the tests on my local machine no problem so we can call it good.

@parrt
Copy link
Member Author

parrt commented Oct 14, 2021

I don't think we use travis anymore right for continuous integration? https://app.travis-ci.com/github/antlr/antlr4 so maybe we should take off the badge from the readme?

@parrt
Copy link
Member Author

parrt commented Oct 14, 2021

Ok, I will wait to hear from people but it sounds like we've merged everything and I can start the release process...

@ericvergnaud
Copy link
Contributor

ericvergnaud commented Oct 14, 2021 via email

@lambersond
Copy link

Will this update fix the CVE-2020-21913 Vulnerability? It looks like there was an open PR trying to fix this. However, it wasn't passing all tests.

@mike-lischke
Copy link
Member

@mike-lischke I try to add the target label as I merge PRs and close bugs.

I'm afraid that won't help. We'd need a notification when a new bug or PR comes in for a particular target language. I hoped there would be a setting to do that, but I didn't find anything.

@marcospassos
Copy link
Contributor

@parrt apparently, we need to fix this issue before releasing. I'm taking a look at this.

@KvanTTT
Copy link
Member

KvanTTT commented Oct 17, 2021

Some important fixes: #3310 Also, I would like to fix this one #2006

@marcospassos
Copy link
Contributor

On the PHP side, we're ready to go IMHO.

@ericvergnaud
Copy link
Contributor

ericvergnaud commented Oct 20, 2021

The Travis CI for Swift/Linux is back, and there are compilation errors such as:

/home/travis/build/antlr/antlr4/runtime/Swift/Tests/Antlr4Tests/ThreadingTests.swift:26:27: error: variable used within its own initial value

    let expectation = expectation(description: "Waiting on async-task")

can someone from the Swift target check ?

@parrt
Copy link
Member Author

parrt commented Oct 22, 2021

@hanjoes Could you take a peek?

@kaby76
Copy link
Contributor

kaby76 commented Oct 22, 2021

I would recommend this change for the Go target (#3284), which fixes 3254--implementing a super class for a lexer for the Go target. Just today there was a question on StackOverflow asking why the Python3 grammar in grammars-v4 doesn't have a Go port. In order to implement the Go target, I'd have to write yet another @lexer::members fork of the Python4Lexer.g4 grammar. I'm willing to port the lexer base class to Go, but I'd really prefer to not write an @lexer::members fork, unless there somehow is a way to use @members in one grammar file for all 8 targets. You only have to look in the directory just above that grammar (https://github.com/antlr/grammars-v4/tree/master/python) to see the maintenance nightmare with uncontrolled forking of the grammar.

@parrt
Copy link
Member Author

parrt commented Oct 22, 2021

@kaby76 merged!

@parrt
Copy link
Member Author

parrt commented Oct 24, 2021

Yay, looks like Swift is passing now. https://github.com/antlr/antlr4/actions/runs/1375420432

@parrt
Copy link
Member Author

parrt commented Oct 27, 2021

it looks like tests are passing locally that I can test...swift/php/javascript I don't think I can test locally.

@kaby76
Copy link
Contributor

kaby76 commented Oct 27, 2021

I'll try the grammars-v4 on the JavaScript target (and also CSharp, Java, Dart, Go) and see how it all works. I disabled the JavaScript target in the CI a few months ago because many grammars were failing to build (because target-specific code was not ported to another target) or run (crashes, un-terminating, or just plain parse errors). I'm psyched to see the fixes.

@kaby76
Copy link
Contributor

kaby76 commented Oct 28, 2021

Much, much improved with JavaScript. Many more grammars now work (so far that I've checked, antlr/antlr2, basic, c, java/java, javascript/javascript). Ty @ericvergnaud ! One regression in the Antlr tool: it doesn't accept Graphemes.g4, whereas it did with 4.9.2 (Graphemes.g4:15:4: string literals and sets cannot be empty: [], haven't debugged it yet). The grammar has problems because it does try to use a fragment in a parser rule.

@ericvergnaud
Copy link
Contributor

ericvergnaud commented Oct 31, 2021 via email

@parrt
Copy link
Member Author

parrt commented Oct 31, 2021

I’m just following the exact same procedure that I always follow according to my documentation

@ericvergnaud
Copy link
Contributor

ericvergnaud commented Oct 31, 2021 via email

@parrt
Copy link
Member Author

parrt commented Oct 31, 2021

@ericvergnaud
Copy link
Contributor

ericvergnaud commented Oct 31, 2021 via email

@parrt
Copy link
Member Author

parrt commented Nov 1, 2021

Something has changed. mvn -DskipTests=True deploy still gives same error I'm afraid.

@parrt
Copy link
Member Author

parrt commented Nov 1, 2021

Hi. @ericvergnaud thinks we've somehow gotten sonatype/nexus in a bad state. Should I change 4.9.3 to 4.9.4, skipping 4.9.3? It'll be a huge hassle to tweak all tagged issues/PRs...anybody know mvn/nexus that can help with the stupid error we're getting?

@parrt
Copy link
Member Author

parrt commented Nov 3, 2021

Hmm...maybe 4.9.3-1-SNAPSHOT...can't find a way to wipe the sonatype/nexus thing. Grrr...any help appreciated.

@parrt
Copy link
Member Author

parrt commented Nov 3, 2021

I have this .m2/settings.xml stuff which always used to work:

   <servers>
        <server>
          <id>sonatype-nexus-staging</id>
          <username>x</username>
          <password>xx</password>
        </server>
        <server>
          <id>sonatype-nexus-snapshots</id>
          <username>x</username>
          <password>xx</password>
        </server>
   </servers>

@parrt
Copy link
Member Author

parrt commented Nov 3, 2021

Ok, i blasted ~/.m2/repositories and now I can't even build:

[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for org.antlr:antlr4-master:4.9.3-SNAPSHOT: Could not transfer artifact org.sonatype.oss:oss-parent:pom:9 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/sonatype/oss/oss-parent/9/oss-parent-9.pom and 'parent.relativePath' points at wrong local POM @ line 9, column 10
 @ 
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]   
[ERROR]   The project org.antlr:antlr4-master:4.9.3-SNAPSHOT (/Users/parrt/antlr/code/antlr4/pom.xml) has 1 error
[ERROR]     Non-resolvable parent POM for org.antlr:antlr4-master:4.9.3-SNAPSHOT: Could not transfer artifact org.sonatype.oss:oss-parent:pom:9 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/sonatype/oss/oss-parent/9/oss-parent-9.pom and 'parent.relativePath' points at wrong local POM @ line 9, column 10: Received fatal alert: protocol_version -> [Help 2]

here is the parent:

	<parent>
		<groupId>org.sonatype.oss</groupId>
		<artifactId>oss-parent</artifactId>
		<version>9</version>
	</parent>

Do i need to change the version?

@parrt
Copy link
Member Author

parrt commented Nov 3, 2021

Intellij reports this for sync'ing with repo:

[ERROR] org.apache.maven.model.resolution.UnresolvableModelException: Failure to transfer org.sonatype.oss:oss-parent:pom:9 from https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced. Original error: Could not transfer artifact org.sonatype.oss:oss-parent:pom:9 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
[ERROR] Maven server structure problem

not even mvn clean works. haha

@parrt
Copy link
Member Author

parrt commented Nov 3, 2021

Maybe it's the "https" vs "http" thing that became popular this year?

@parrt
Copy link
Member Author

parrt commented Nov 3, 2021

Anyway, i guess no 4.9.3 release as I can't figure it out. PhDs aren't as useful as they used to be I guess haha

@ericvergnaud
Copy link
Contributor

ericvergnaud commented Nov 4, 2021 via email

@parrt
Copy link
Member Author

parrt commented Nov 4, 2021 via email

@hanjoes
Copy link
Member

hanjoes commented Nov 4, 2021

Yay, looks like Swift is passing now. https://github.com/antlr/antlr4/actions/runs/1375420432

@parrt @ericvergnaud sorry was carried away by life/work. Glad it's solved now!

@ericvergnaud
Copy link
Contributor

ericvergnaud commented Nov 4, 2021 via email

@ericvergnaud
Copy link
Contributor

ericvergnaud commented Nov 5, 2021 via email

@parrt
Copy link
Member Author

parrt commented Nov 6, 2021

I am rerunning scripts/github_release_notes.py and updating the release notes draft: https://github.com/antlr/antlr4/releases/edit/untagged-1690fce37cd84949ddcb

Ah. it looks like you're done so I just published it: https://github.com/antlr/antlr4/releases/tag/4.9.3

@ericvergnaud
Copy link
Contributor

Missing a few runtimes to publish, check my last email

@parrt
Copy link
Member Author

parrt commented Nov 6, 2021

For C++ I think we just have to run source zip thing and pushed to the website download area. The others are all published in another way.

@ericvergnaud
Copy link
Contributor

ericvergnaud commented Nov 6, 2021 via email

@parrt
Copy link
Member Author

parrt commented Nov 6, 2021

You're the king! You should have the pleasure of hitting the close button on this issue!

@ericvergnaud
Copy link
Contributor

Just need you to publish Dart, and I'll sure click!

@parrt
Copy link
Member Author

parrt commented Nov 6, 2021

Done! https://pub.dev/packages/antlr4/versions/4.9.3

@ericvergnaud
Copy link
Contributor

Hooray !

@parrt
Copy link
Member Author

parrt commented Nov 6, 2021

thanks everyone!!!!

@parrt
Copy link
Member Author

parrt commented Nov 6, 2021

@bjansen a plugin release would be great, if you have time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants