Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser.setProfile() should keep settings like prediction mode #809

Closed
parrt opened this issue Jan 31, 2015 · 0 comments · Fixed by #811
Closed

Parser.setProfile() should keep settings like prediction mode #809

parrt opened this issue Jan 31, 2015 · 0 comments · Fixed by #811
Labels
comp:runtime parsers status:fixed type:improvement
Milestone
4.5.1

Comments

@parrt
Copy link
Member

parrt commented Jan 31, 2015

Doing

parser.getInterpreter().setPredictionMode(PredictionMode.LL_EXACT_AMBIG_DETECTION);
parser.setProfile(true);

Does not set LL_EXACT_AMBIG_DETECTION mode. setProfile() creates new ATN interp, which wipes mode.
parrt added a commit to parrt/antlr4 that referenced this issue Jan 31, 2015
@parrt
Fixes antlr#809.
822d61a
@parrt parrt mentioned this issue Jan 31, 2015
Merged
@parrt parrt added this to the 4.5.1 milestone May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:runtime parsers status:fixed type:improvement
Projects
None yet
Milestone
4.5.1
Development

Successfully merging a pull request may close this issue.

Fix 809 antlr/antlr4
1 participant
@parrt