Fixed null pointer exception for JS target #1736
Merged
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For JavaScript target,
getToken
andgetChild
methods inParserRuleContext.js
did not check ifthis.children
isnull
as code for Java target did. I added the two if statements Java implementation has in these methods.For an example of where the problem arises, consider the rule
If the input is empty (i.e.
statements
is not matched), the visitor's methodfails on the
ctx.statements()
call, because of an attempt to accessthis.children.length
inParserRuleContext.js
'sgetChild
method.Meanwhile, the Java implementation of the same thing has no problem calling
ctx.statements()
.