Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TimeLexerSpeed when run from jar #1787

Closed

Conversation

bhamiltoncx
Copy link
Contributor

This fixes the issue where we were passing URLs to APIs which expected filenames:

#1781 (comment)

I had to use the Reader API of ANTLRInputStream since the InputStream constructor constructs an InputStreamReader() without specifying a Charset.

That API sadly uses the default Charset from the test runner's environment, which is not necessarily UTF-8.

I also removed the ASCII time tests, since they were functionally identical to the UTF-8 test.

The timings are a bit different now, since we include time to read the file consistently across the CharStream implementations.

@parrt
Copy link
Member

parrt commented Mar 23, 2017

I forgot to hit send on an email to ya. i added mem info. can you pull again to resolve conflicts?

@parrt parrt closed this Mar 23, 2017
@parrt parrt added this to the 4.7 milestone Mar 23, 2017
@bhamiltoncx
Copy link
Contributor Author

bhamiltoncx commented Mar 23, 2017 via email

@bhamiltoncx bhamiltoncx deleted the fix-time-test-resources branch March 23, 2017 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants