[dotnet] speed up tests; rename runtime dll ready for nuget #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test dir removal not recursive
|
mmm… from the below link, it seems to still to be too slow on Mac:
https://travis-ci.org/antlr/antlr4/builds/226877875 <https://travis-ci.org/antlr/antlr4/builds/226877875>
… Le 29 avr. 2017 à 00:20, Dong Xie ***@***.***> a écrit :
@parrt <https://github.com/parrt> @ericvergnaud <https://github.com/ericvergnaud>
Renamed dll to Antlr4.Runtime.Core as Eric suggested.
dotnet test on Mac now able to finish successfully.
dotnet test on Linux runs faster.
The cmd to pack nuget package is dotnet pack Antlr4.Runtime.dotnet.csproj then we'll get a nupkg inside bin/
In fact we can push the nupkg automatically (nightly build would be great) if we want. Let me know.
You can view, comment on, or merge this pull request online at:
#1845 <#1845>
Commit Summary
[dotnet] try to get test run faster; update from 1.0.1 to 1.0.3; fix test dir removal not recursive
[dotnet] fix again for the test speed up
File Changes
M .travis/before-install-linux-dotnet.sh <https://github.com/antlr/antlr4/pull/1845/files#diff-0> (2)
M .travis/before-install-osx-dotnet.sh <https://github.com/antlr/antlr4/pull/1845/files#diff-1> (4)
M .travis/run-tests-dotnet.sh <https://github.com/antlr/antlr4/pull/1845/files#diff-2> (10)
M runtime-testsuite/test/org/antlr/v4/test/runtime/csharp/BaseCSharpTest.java <https://github.com/antlr/antlr4/pull/1845/files#diff-3> (56)
M runtime/CSharp/runtime/CSharp/Antlr4.Runtime/Antlr4.Runtime.dotnet.csproj <https://github.com/antlr/antlr4/pull/1845/files#diff-4> (17)
Patch Links:
https://github.com/antlr/antlr4/pull/1845.patch <https://github.com/antlr/antlr4/pull/1845.patch>
https://github.com/antlr/antlr4/pull/1845.diff <https://github.com/antlr/antlr4/pull/1845.diff>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1845>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADLYJOZ5kf5a3wALFX-8l5KsGSKNO5Puks5r0hHSgaJpZM4NLset>.
|
|
That PR build could be a one-off, I've restarted my pull run 3 times, all finished much faster. |
|
Ok, seems to work when re-running it manually. |
|
ping @ericvergnaud would be great to have your follow up PR so that this finally makes it to the NuGet source. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@parrt @ericvergnaud https://travis-ci.org/xied75/antlr4/builds/226855441
Renamed dll to Antlr4.Runtime.Core as Eric suggested.
dotnet test on Mac now able to finish successfully.
dotnet test on Linux runs faster.
The cmd to pack nuget package is
dotnet pack Antlr4.Runtime.dotnet.csprojthen we'll get a nupkg inside bin/In fact we can push the nupkg automatically (nightly build would be great) if we want. Let me know.