CMake build fixes for Visual Studio #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unsupported cmd line options (gcc). Disable warning for DLL.
mike-lischke
approved these changes
Oct 11, 2017
|
Ooops. Please sign the contributors file; otherwise I have to back this out. |
|
actually I will back out and then you can make a new PR with the sig. sorry for the hassles. |
|
@gendalph Can you help me out by making a new PR with these changes? I can't figure out the git to revert the revert :) thanks! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unsupported cmd line options (gcc).
Disable tons of warning for DLL.
Enable parallel build.
cmake 3.9.2
Microsoft Visual Studio Community 2017 Preview (2)
Version 15.4.0 Preview 1.0
Installed Version: Community
Visual C++ 2017 00369-60000-00001-AA769
Microsoft Visual C++ 2017