Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1855, #2211 #2213

Merged
merged 9 commits into from
Jun 16, 2018
Merged

Fix #1855, #2211 #2213

merged 9 commits into from
Jun 16, 2018

Conversation

eternalphane
Copy link
Contributor

Make clone() function of antlrcpp::Any::Derive return either new Derive* or nullptr depending on whether template type is copy-constructible.

Related: #1855

@eternalphane eternalphane changed the title let Any::Derived<T>::clone depend on whether T is copy-constructible Fix #1855, #2211 Feb 3, 2018
@eternalphane eternalphane mentioned this pull request Mar 26, 2018
Closed
@daniele-niero
Copy link

Hello,

Is this already merged to the master branch? I have compiled the cpp runtime and I still have the problem.

@mike-lischke
Copy link
Member

mike-lischke commented May 9, 2018 •
edited
Loading

No it's not merged yet. Otherwise this PR would be closed already.

@eternalphane
Copy link
Contributor Author

Ping...

@mike-lischke
Copy link
Member

mike-lischke commented Jun 16, 2018 •
edited
Loading

@parrt This is a pure C++ runtime patch and all checks passed. Can you please merge?

@parrt parrt added this to the 4.7.2 milestone Jun 16, 2018
@parrt parrt merged commit 98dc2c0 into antlr:master Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-lischke mike-lischke mike-lischke approved these changes

Assignees
No one assigned
Labels
comp:runtime target:cpp
Projects
None yet
Milestone
4.7.2
Development

Successfully merging this pull request may close these issues.
4 participants
@eternalphane @daniele-niero @mike-lischke @parrt