Javascript: fix some cyclic dependencies #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carocad
changed the title
carocad
changed the title
|
@ericvergnaud unfortunately I cannot add a reviewer to github anymore ... dont know why. So I am not sure if you have already checked this :) ? |
|
@parrt blessed |
|
Hi guys, we have conflicts after merging previous... |
Let me take a look. EDIT: fixed :) |
…eContext.js check for RuleNode instead of RuleContext since that it the only implementation (RuleNode -> RuleContext -> ParserRuleContext)
|
hello ? anyone there ? |
|
@parrt blessed, sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up on #2749 specifically this comment
This PR removes 2 of the 3 cyclic dependencies from before:
Number 2 and 3 are eliminated.
The solution for this specific case is to check for
RuleNodeinterface since bothRuleContextandParserRuleContextimplement it (RuleNode -> RuleContext -> ParserRuleContext) and sinceRuleContextis the only implementation ofRuleNodethe checks are equivalent.NOTE: On Javascript the RuleNode didnt declare the getRuleContext as in Java so I added it to make it consistent and to make it work as described above.