[C++ codegen] Remove use of the u8"" string literal prefix #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to C++20, the type of a "UTF-8 encoded string literal" is char const * - i.e. it is exactly the same as a non-prefixed string literal (they are semantically different, but technically the same). Since C++20, the type of a UTF-8 encoded string literal is changed to char8_t const * - which is not convertable to char const *. Even in C++20, there is no actual change to how characters are stored, only the type is changed (they are now semantically different, and supposed to be technically different - but nothing in the language actually uses the semantics). In short, removing the u8"" prefix has no effect prior to C++20, and simply allows compilation to succeed since c++20.
mike-lischke
approved these changes
Sep 10, 2020
|
@parrt Small C++ change, ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to C++20, the type of a "UTF-8 encoded string literal" is
char const *- i.e. it is exactly the same as a non-prefixed string literal (they are semantically different, but technically the same).Since C++20, the type of a UTF-8 encoded string literal is changed to
char8_t const *- which is not convertable tochar const *. Even in C++20, there is no actual change to how characters are stored, only the type is changed (they are now semantically different, and supposed to be technically different - but nothing in the language actually uses the semantics).In short, removing the u8"" prefix has no effect prior to C++20, and simply allows compilation to succeed since C++20.
Fixes #2844