[C++] Refactor Guid to use std::array instead of std::vector

[jcking]

Use std::array instead of std::vector. The size of GUIDs is static and always 16-bytes. Using std::array allows us to avoid heap allocations. This also moves Guid out of the global namespace and into antlrcpp.

[jcking]

@mike-lischke PTAL

[mike-lischke]

Love the patch. You even took care to fix the wrong formatting.

The only thing I wonder about is: should we use static_cast instead of the C-style casts everywhere? I should have used static casts from the beginning.

[jcking]

Yeah, we should use static_cast. Let me fix the remainder.

[jcking]

Love the patch. You even took care to fix the wrong formatting.

The only thing I wonder about is: should we use static_cast instead of the C-style casts everywhere? I should have used static casts from the beginning.

Changed the remainder in operator<< to use static_cast instead of C-style cast.

[jcking]

Am I supposed to mirror changes into runtime-testsuite/target/classes/Cpp?

[jcking]

Am I supposed to mirror changes into runtime-testsuite/target/classes/Cpp?

nvm that looks to be auto-generated. Looks like I need to figure out why its using an old version.

[jcking]

Am I supposed to mirror changes into runtime-testsuite/target/classes/Cpp?

nvm that looks to be auto-generated. Looks like I need to figure out why its using an old version.

Nvm, its good. Github decided to email me about previous attempts which I knew were going to fail.

[mike-lischke]

@parrt This is a C++ only patch. It can be merged for the upcoming release oder after that. Either is fine for me.

[parrt]

I could swear I merged this manually but will do it formally with github