Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that only the tokens needed are fetched #3722

Merged
merged 1 commit into from
May 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion runtime/Go/antlr/common_token_stream.go
Original file line number Diff line number Diff line change
Expand Up @@ -331,10 +331,12 @@ func (c *CommonTokenStream) GetTextFromRuleContext(interval RuleContext) string

func (c *CommonTokenStream) GetTextFromInterval(interval *Interval) string {
c.lazyInit()
c.Fill()

if interval == nil {
c.Fill()
interval = NewInterval(0, len(c.tokens)-1)
} else {
c.Sync(interval.Stop)
jcking marked this conversation as resolved.
Show resolved Hide resolved
}

start := interval.Start
Expand Down
24 changes: 24 additions & 0 deletions runtime/Go/antlr/common_token_stream_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -152,3 +152,27 @@ func TestCommonTokenStreamCannotConsumeEOF(t *testing.T) {
assert.Equal(1, tokens.Size())
assert.Panics(tokens.Consume)
}

func TestCommonTokenStreamGetTextFromInterval(t *testing.T) {
assert := assertNew(t)
lexEngine := &commonTokenStreamTestLexer{
tokens: []Token{
newTestCommonToken(1, " ", LexerHidden), // 0
newTestCommonToken(1, "x", LexerDefaultTokenChannel), // 1
newTestCommonToken(1, " ", LexerHidden), // 2
newTestCommonToken(1, "=", LexerDefaultTokenChannel), // 3
newTestCommonToken(1, "34", LexerDefaultTokenChannel), // 4
newTestCommonToken(1, " ", LexerHidden), // 5
newTestCommonToken(1, " ", LexerHidden), // 6
newTestCommonToken(1, ";", LexerDefaultTokenChannel), // 7
newTestCommonToken(1, " ", LexerHidden), // 8
newTestCommonToken(1, "\n", LexerHidden), // 9
newTestCommonToken(TokenEOF, "", LexerDefaultTokenChannel), // 10
},
}
tokens := NewCommonTokenStream(lexEngine, TokenDefaultChannel)
assert.Equal("x", tokens.GetTextFromInterval(&Interval{Start: 1, Stop: 1}))
assert.Equal(len(tokens.tokens), 2)
assert.Equal(" x =34 ; \n", tokens.GetTextFromInterval(nil))
assert.Equal(len(tokens.tokens), 11)
}
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ public String getText(Interval interval) {
int start = interval.a;
int stop = interval.b;
if ( start<0 || stop<0 ) return "";
fill();
sync(stop);
if ( stop>=tokens.size() ) stop = tokens.size()-1;

StringBuilder buf = new StringBuilder();
Expand Down