-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Remove libuuid dependency #3787
Conversation
libuuid and its headers are not referenced anywhere, so remove it. Signed-off-by: Bryan Tan <bryantan@technius.net>
Makes me a bit nervous... @mike-lischke or @jcking might have an opinion. |
Won't removing the lib cause linker errors for others because of missing symbols? How can that work without the linked uuid lib? |
As far as I can tell, there is no |
Oh! @mike-lischke Isn't this related to something we removed recently in the ATN serialization? We used to have a UUID in there but it has been removed from all target. |
Yes, that's what I thought too. I did a quick search and cannot find any reference to uuid. So it looks like the lib reference is just an artifact and can be removed. IIRC @KvanTTT wrote the patch that removed the uuid stuff, right? |
Thanks everyone |
You can remove any libuuid references. I must have missed one. C++ no
longer had any external dependencies, aside from th standard library of
course.
…On Sat, Aug 6, 2022, 10:41 AM Terence Parr ***@***.***> wrote:
Merged #3787 <#3787> into dev.
—
Reply to this email directly, view it on GitHub
<#3787 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHTURWMTU6AXXEIZ2TNFRDVX2PUVANCNFSM53URY3YA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This PR removes the libuuid dependency from the C++ runtime, since the libuuid headers are not referenced anywhere. Note that libuuid is only used as a dependency on Linux.
Context: I'm working on a C++ project that uses Nix to manage dependencies and was trying to use the CMake ANTLR config file (as generated by
-DANTLR_INSTALL=on
), but I was getting linker errors in my project as 1) libuuid is not checked for in the exported CMake config file; and 2) an unnecessary-luuid
was added to the antlr-runtime target's interface link libraries.