Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added example using Cambalache ui file #309

Closed
wants to merge 7 commits into from

Conversation

J-Kappes
Copy link

I would have liked to use an AdwApplicationWindow instead of a GtkApplicationWindow for the root widget, but I couldn't get it to work.

@antoyo
Copy link
Owner

antoyo commented Jul 3, 2023

Sorry, I forgot about this PR.

How is this different that this example?

@J-Kappes
Copy link
Author

J-Kappes commented Jul 4, 2023

It just uses a gtk-4.10 ui file made with Cambalache which seems to be bound to replace Glade which doesn't support gtk-4

@antoyo
Copy link
Owner

antoyo commented Jul 4, 2023

It seems you forgot to add some dev-dependencies.

relm-examples/Cargo.toml Outdated Show resolved Hide resolved
fixup: dependencies -> dev-dependencies in Cargo.toml

Co-authored-by: antoyo <antoyo@users.noreply.github.com>
@antoyo
Copy link
Owner

antoyo commented Jul 6, 2023

The CI fails because of an old version of glib.
Please try to update these lines to:

    runs-on: ubuntu-22.04

Comment on lines 12 to 13
container:
image: ubuntu:20.04
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to remove these two lines, otherwise, this will still run on Ubuntu 20.04, I believe.

@antoyo
Copy link
Owner

antoyo commented Jul 10, 2023

Hmm. The last CI attempt tries to download gtk4. Is this normal?

@J-Kappes
Copy link
Author

sounds normal to me.

@antoyo
Copy link
Owner

antoyo commented Jul 17, 2023

Why? relm doesn't support gtk4.

If so, please add the corresponding Ubuntu package in the CI.

@J-Kappes
Copy link
Author

I'm confused. I said that I added an example using a gtk-4 ui file. I didn't realize gtk-4 wasn't supported. Would you even want this merged, then? If so, I'll see that I make the change.

@antoyo
Copy link
Owner

antoyo commented Jul 24, 2023

Sorry, I forgot about this PR.

Yeah, since this example very similar to the glade one and gtk-4 isn't supported, I would see little value in merging this PR. Sorry about that.

@J-Kappes
Copy link
Author

OK, no prob.

@J-Kappes J-Kappes closed this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants