Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bullet): 子弹图 添加单数值range/measures 、 多 target 数据修改兼容 #3231

Merged
merged 6 commits into from
Jun 6, 2022
Merged

fix(bullet): 子弹图 添加单数值range/measures 、 多 target 数据修改兼容 #3231

merged 6 commits into from
Jun 6, 2022

Conversation

ai-qing-hai
Copy link
Contributor

@ai-qing-hai ai-qing-hai commented Jun 1, 2022 •
edited
Loading

PR includes

  • color.target 颜色可以配置数组和方法
  • buttetStyle.target 可以配置回调
  • range/measures 可以配置单个数值
Before After
更改前 range 和 measures 只能传入数组，不然报错 ，target 的颜色color 不起作用 更改后 range 和 measures 支持单个数值， target 的颜色配置起效果
image image

@github-actions github-actions bot added the bugfix label Jun 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022 •
edited
Loading

🎊 PR Preview 2dadc37 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-3231.surge.sh?type=diff&date=2022-06-06

🕐 Build time: 63.231s

🤖 By Surge Ui Insight

@github-actions github-actions bot added bugfix and removed bugfix labels Jun 6, 2022
@github-actions github-actions bot added bugfix and removed bugfix labels Jun 6, 2022
@github-actions github-actions bot added bugfix and removed bugfix labels Jun 6, 2022
visiky
visiky reviewed Jun 6, 2022
View reviewed changes
src/plots/bullet/utils.ts Outdated Show resolved Hide resolved
visiky
visiky reviewed Jun 6, 2022
View reviewed changes
src/plots/bullet/utils.ts Outdated Show resolved Hide resolved
@visiky visiky merged commit 3d076de into master Jun 6, 2022
@visiky visiky deleted the fix-bullet-moretarget branch June 6, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky left review comments

Assignees
No one assigned
Labels
bugfix PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ai-qing-hai @visiky