Implement primitive typenames #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anweiss
reviewed
Jul 13, 2023
anweiss
reviewed
Jul 31, 2023
anweiss
reviewed
Jul 31, 2023
|
@anweiss It's probably worth noting that this does not fix the major bug outlined in the above issue. Sadly CDDL is heavily context-dependent, so in order to parse CDDL properly, you need to either ask that users must write their CDDL in order of "more primitive" groups or implement deferred parsing which defers the instantiation of a symbol till all symbols can be resolved. This latter solution is actually the only true way to implement this because generic types require this. |
|
agreed, thanks @jrandolf! We can make note of this in the README |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal implementation that doesn't expose any type names at the moment.
Bug: #193