Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract precompile-error crate #2300

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kevinheavey
Copy link

@kevinheavey kevinheavey commented Jul 26, 2024

Problem

Pulling out a solana_sdk::transaction crate requires pulling out solana_sdk::precompiles which requires pulling out solana_sdk::ed25519_instruction. But ed25519_instruction depends on the PrecompileError type from solana_sdk::precompiles, so PrecompileError needs to be pulled out to avoid a circular dependency

Summary of Changes

  • Move PrecompileError to its own crate
  • Remove thiserror from the new crate
  • Update PrecompileError usage in this repo
  • Re-export with deprecation

@kevinheavey kevinheavey force-pushed the precompile-error-crate branch 2 times, most recently from 5b42e9b to 26a8c80 Compare September 8, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

1 participant