forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
svm: allow conflicting transactions in entries #2702
Draft
2501babe
wants to merge
25
commits into
anza-xyz:master
Choose a base branch
from
2501babe:20240822_svmconflicts_attempt3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
svm: allow conflicting transactions in entries #2702
2501babe
wants to merge
25
commits into
anza-xyz:master
from
2501babe:20240822_svmconflicts_attempt3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2501babe
force-pushed
the
20240822_svmconflicts_attempt3
branch
3 times, most recently
from
August 29, 2024 08:56
7313b0f
to
022062e
Compare
2501babe
force-pushed
the
20240822_svmconflicts_attempt3
branch
from
September 7, 2024 02:43
9ce1b29
to
2769e19
Compare
2501babe
force-pushed
the
20240822_svmconflicts_attempt3
branch
from
September 10, 2024 14:48
2769e19
to
62b40b2
Compare
2501babe
force-pushed
the
20240822_svmconflicts_attempt3
branch
from
September 11, 2024 12:54
34dd214
to
bbcd12c
Compare
using acocunts map for fee payer validation, and wrote a handful of initial tests for this
imo removing the override test rather than hacking it with load_accounts is correct because the function no long has any concept of overrides at all also note that because inspect doesnt operate here either, we have no need for the callback all this processing happens once and once only, per batch, in load_accounts!
2501babe
force-pushed
the
20240822_svmconflicts_attempt3
branch
from
September 13, 2024 15:13
bbcd12c
to
47f647a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(still under dev, new branch because reimplementing was easier than rebasing on latest changes)
Problem
Summary of Changes
Fixes #