Skip to content

Commit

Permalink
Bug 1681261 - Test failure reduction for inputConnection_sendKeyEvent…
Browse files Browse the repository at this point in the history
…. r=geckoview-reviewers,calu

To reduce test failure of inputConnection_sendKeyEvent, I would like to add more workaround.
As long as I run this fix in local 200 times, it is no failure.

Differential Revision: https://phabricator.services.mozilla.com/D132931
  • Loading branch information
makotokato committed Dec 7, 2021
1 parent b1296e4 commit baa3370
Showing 1 changed file with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -626,9 +626,11 @@ class TextInputDelegateTest : BaseSessionTest() {
promise.value

// TODO(m_kato)
// Since geckoview-junit doesn't attach View, there is no way to wait for correct selection data
// assertTextAndSelection("Can select using key event", ic,
// "frabar", 6, 5)
// Since geckoview-junit doesn't attach View, there is no way to wait for correct selection data.
// So Sync shadow text to avoid failures.
syncShadowText(ic)
assertTextAndSelection("Can select using key event", ic,
"frabar", 6, 5)

promise = mainSession.evaluatePromiseJS(
when (id) {
Expand Down

0 comments on commit baa3370

Please sign in to comment.