Fix basic storybook

apache-superset · Mar 29, 2021 · 10b5035 · 10b5035
1 parent 2c2fbd5
commit 10b5035
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 24 deletions.
diff --git a/packages/superset-ui-chart-controls/src/components/InfoTooltipWithTrigger.tsx b/packages/superset-ui-chart-controls/src/components/InfoTooltipWithTrigger.tsx
@@ -52,7 +52,7 @@ export function InfoTooltipWithTrigger({
       onClick={onClick}
       onKeyPress={
         onClick &&
-        ((event: React.KeyboardEvent) => {
+        (event => {
           if (event.key === 'Enter' || event.key === ' ') {
             onClick();
           }

diff --git a/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-table/TableStories.tsx b/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-table/TableStories.tsx
@@ -78,7 +78,7 @@ export const basic = ({ width, height }) => (
     }}
     width={width}
     height={height}
-    queriesData={[{ data: basicData }]}
+    queriesData={[basicData]}
     formData={basicFormData}
   />
 );

diff --git a/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-table/testData.ts b/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-table/testData.ts
@@ -16,28 +16,38 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { TableChartProps } from '@superset-ui/plugin-chart-table/src';
+import { ChartDataResponseResult, GenericDataType } from '@superset-ui/core/src';
+import { TableChartFormData, TableChartProps } from '@superset-ui/plugin-chart-table/src';
 // @ts-ignore
 // eslint-disable-next-line import/extensions
 import birthNamesJson from './birthNames.json';
 
 export const birthNames = (birthNamesJson as unknown) as TableChartProps;
-export const basicFormData = {
-  alignPn: false,
-  colorPn: false,
-  includeSearch: false,
+
+export const basicFormData: TableChartFormData = {
+  datasource: '1__table',
+  viz_type: 'table',
+  align_pn: false,
+  color_pn: false,
+  include_search: true,
   metrics: ['sum__num', 'MAX(ds)'],
-  orderDesc: true,
-  pageLength: 0,
-  percentMetrics: null,
-  showCellBars: true,
-  tableFilter: false,
-  tableTimestampFormat: 'smart_date',
-  timeseriesLimitMetric: null,
+  order_desc: true,
+  page_length: 0,
+  percent_metrics: null,
+  show_cell_bars: true,
+  table_filter: false,
+  table_timestamp_format: 'smart_date',
 };
-export const basicData = {
-  columns: ['name', 'sum__num', 'MAX(ds)', 'Abc.com'],
-  records: [
+
+export const basicData: Partial<ChartDataResponseResult> = {
+  colnames: ['name', 'sum__num', 'MAX(ds)', 'Abc.com'],
+  coltypes: [
+    GenericDataType.STRING,
+    GenericDataType.NUMERIC,
+    GenericDataType.TEMPORAL,
+    GenericDataType.STRING,
+  ],
+  data: [
     {
       name: 'Michael',
       sum__num: 2467063,

diff --git a/plugins/plugin-chart-table/src/utils/DateWithFormatter.ts b/plugins/plugin-chart-table/src/utils/DateWithFormatter.ts
@@ -43,12 +43,11 @@ export default class DateWithFormatter extends Date {
 
     this.input = input;
     this.formatter = formatter;
-  }
-
-  toString(): string {
-    if (this.formatter === String) {
-      return String(this.input);
-    }
-    return this.formatter ? this.formatter(this) : Date.toString.call(this);
+    this.toString = (): string => {
+      if (this.formatter === String) {
+        return String(this.input);
+      }
+      return this.formatter ? this.formatter(this) : Date.toString.call(this);
+    };
   }
 }