Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: check node and npm version in release workflow #1454

Merged

Conversation

zhaoyongjie
Copy link
Contributor

🏠 Internal
check node and npm version in release workflow

@zhaoyongjie zhaoyongjie requested a review from a team as a code owner November 3, 2021 08:27
@vercel
Copy link

vercel bot commented Nov 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/G3FjEssZuri8hZFaPFTBDsFioAvg
✅ Preview: https://superset-ui-git-fork-zhaoyongjie-checknodenpmversion-superset.vercel.app

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #1454 (a9a5ae1) into master (4262d4a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1454   +/-   ##
=======================================
  Coverage   30.48%   30.48%           
=======================================
  Files         498      498           
  Lines       10019    10019           
  Branches     1691     1691           
=======================================
  Hits         3054     3054           
  Misses       6719     6719           
  Partials      246      246           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4262d4a...a9a5ae1. Read the comment docs.

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scripts/lernaVersion.sh Outdated Show resolved Hide resolved
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this check!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants