Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: Pass dashboardId to ColorSchemeControl #1467

Merged
merged 1 commit into from
Nov 12, 2021
Merged

chore: Pass dashboardId to ColorSchemeControl #1467

merged 1 commit into from
Nov 12, 2021

Conversation

geido
Copy link
Member

@geido geido commented Nov 12, 2021

SUMMARY

This PR is a dependency for the PR apache/superset#17422. It passes the dashboardId to the ColorSchemeControl

See apache/superset#17422 for more information

@geido geido requested a review from a team as a code owner November 12, 2021 11:32
@vercel
Copy link

vercel bot commented Nov 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/4DgUNXJ2ULKNdMPNnLzTX4ADR9mL
✅ Preview: https://superset-ui-git-fork-geido-chore-customlabelcol-08e3f1-superset.vercel.app

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #1467 (6364ec7) into master (6aee3ac) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1467      +/-   ##
==========================================
- Coverage   30.94%   30.91%   -0.03%     
==========================================
  Files         502      502              
  Lines       10212    10220       +8     
  Branches     1760     1762       +2     
==========================================
  Hits         3160     3160              
- Misses       6800     6808       +8     
  Partials      252      252              
Impacted Files Coverage Δ
...et-ui-chart-controls/src/shared-controls/index.tsx 35.35% <0.00%> (-0.37%) ⬇️
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aee3ac...6364ec7. Read the comment docs.

Copy link
Contributor

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants