-
Notifications
You must be signed in to change notification settings - Fork 273
feat(legacy-preset-chart-nvd3): add a new label type to pie chart #699
Conversation
add a new label type that can display key value and percent Signed-off-by: Stuart Hu <shijiehu@improbable.io>
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/q31bcd8t5 |
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
==========================================
- Coverage 24.21% 24.19% -0.02%
==========================================
Files 338 339 +1
Lines 7607 7617 +10
Branches 924 924
==========================================
+ Hits 1842 1843 +1
- Misses 5692 5701 +9
Partials 73 73
Continue to review full report at Codecov.
|
Signed-off-by: Stuart Hu <shijiehu@improbable.io>
Signed-off-by: Stuart Hu <shijiehu@improbable.io>
Also I would like to know how to release a new version of this plugin. |
@mistercrunch here is the fix for #697 |
Signed-off-by: Stuart Hu <shijiehu@improbable.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice enhancement and refactor!
🏆 Enhancements
add a new label type that can display key value and percent
Signed-off-by: Stuart Hu shijiehu@improbable.io