Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(legacy-preset-chart-nvd3): add a new label type to pie chart #699

Merged
merged 8 commits into from
Jul 27, 2020
Merged

feat(legacy-preset-chart-nvd3): add a new label type to pie chart #699

merged 8 commits into from
Jul 27, 2020

Conversation

stuarthu
Copy link
Contributor

@stuarthu stuarthu commented Jul 23, 2020

🏆 Enhancements

add a new label type that can display key value and percent

Signed-off-by: Stuart Hu shijiehu@improbable.io

截屏2020-07-23 18 45 39

add a new label type that can display key value and percent

Signed-off-by: Stuart Hu <shijiehu@improbable.io>
@stuarthu stuarthu requested a review from a team as a code owner July 23, 2020 10:37
@vercel
Copy link

vercel bot commented Jul 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/q31bcd8t5
✅ Preview: https://superset-ui-git-fork-stuarthu-master.superset.vercel.app

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #699 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
- Coverage   24.21%   24.19%   -0.02%     
==========================================
  Files         338      339       +1     
  Lines        7607     7617      +10     
  Branches      924      924              
==========================================
+ Hits         1842     1843       +1     
- Misses       5692     5701       +9     
  Partials       73       73              
Impacted Files Coverage Δ
plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js 0.00% <0.00%> (ø)
packages/superset-ui-query/src/extractExtras.ts 100.00% <0.00%> (ø)
packages/superset-ui-query/src/processFilters.ts 100.00% <0.00%> (ø)
...kages/superset-ui-query/src/types/QueryFormData.ts 100.00% <0.00%> (ø)
...rt-parallel-coordinates/src/ParallelCoordinates.js 0.00% <0.00%> (ø)
...allel-coordinates/src/ReactParallelCoordinates.jsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2923973...11a2478. Read the comment docs.

Signed-off-by: Stuart Hu <shijiehu@improbable.io>
Signed-off-by: Stuart Hu <shijiehu@improbable.io>
@stuarthu
Copy link
Contributor Author

stuarthu commented Jul 23, 2020

Also I would like to know how to release a new version of this plugin.
I followed https://github.com/apache-superset/superset-ui/blob/master/CONTRIBUTING.md
But when I execute yarn run release it report error says package-lock.json is ignored.
This is because yarn run release edited that file.
But according to the repo we do not use package-lock.json any more but yarn.lock.
Maybe its just I don't have the permission to release a new version of superset-ui.

@stuarthu
Copy link
Contributor Author

@mistercrunch here is the fix for #697

@vercel vercel bot temporarily deployed to Preview July 24, 2020 10:58 Inactive
@vercel vercel bot temporarily deployed to Preview July 24, 2020 11:02 Inactive
Signed-off-by: Stuart Hu <shijiehu@improbable.io>
@stuarthu
Copy link
Contributor Author

截屏2020-07-24 19 09 39

@stuarthu
Copy link
Contributor Author

截屏2020-07-27 09 21 33

@stuarthu stuarthu requested a review from ktmud July 27, 2020 01:23
Copy link
Contributor

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice enhancement and refactor!

@ktmud ktmud merged commit 62e7c69 into apache-superset:master Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants