Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: add sort by metric for charts with multiple metrics #952

Merged
merged 3 commits into from
Feb 15, 2021

Conversation

maloun96
Copy link
Contributor

@maloun96 maloun96 commented Feb 10, 2021

SUMMARY

Add sort by metric charts with multiple metrics

Associated with: apache/superset#13057

pivot-table

pivot

parallel-coordinates

parallel-coordinates

treemap

treemap

@maloun96 maloun96 requested a review from a team as a code owner February 10, 2021 14:39
@vercel
Copy link

vercel bot commented Feb 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/efvwbu525
✅ Preview: https://superset-ui-git-fork-maloun96-pivot-table.superset.now.sh

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #952 (0b30c7f) into master (18f45b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #952   +/-   ##
=======================================
  Coverage   27.67%   27.67%           
=======================================
  Files         401      401           
  Lines        8249     8249           
  Branches     1138     1138           
=======================================
  Hits         2283     2283           
  Misses       5830     5830           
  Partials      136      136           
Impacted Files Coverage Δ
...gin-chart-parallel-coordinates/src/controlPanel.ts 0.00% <ø> (ø)
...egacy-plugin-chart-pivot-table/src/controlPanel.ts 0.00% <ø> (ø)
...ns/legacy-plugin-chart-treemap/src/controlPanel.ts 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18f45b6...0b30c7f. Read the comment docs.

@maloun96 maloun96 changed the title feat(legacy-plugin-chart-pivot-table): subject Add sort by metric feat: subject Add sort by metric for charts with multiple metrics Feb 11, 2021
@ktmud ktmud changed the title feat: subject Add sort by metric for charts with multiple metrics feat: add sort by metric for charts with multiple metrics Feb 15, 2021
@ktmud ktmud merged commit d29e1cd into apache-superset:master Feb 15, 2021
ktmud pushed a commit that referenced this pull request Feb 18, 2021
Including
  - legacy-plugin-chart-pivot-table
  - legacy-plugin-chart-parallel-coordinates
  - legacy-plugin-chart-treemap
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants