Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-2384] Set flask to 0.12.2 #3272

Closed
wants to merge 1 commit into from
Closed

[AIRFLOW-2384] Set flask to 0.12.2 #3272

wants to merge 1 commit into from

Conversation

ese
Copy link
Contributor

@ese ese commented Apr 27, 2018

Make sure you have checked all steps below.

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@codecov-io
Copy link

Codecov Report

Merging #3272 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3272   +/-   ##
=======================================
  Coverage   75.78%   75.78%           
=======================================
  Files         197      197           
  Lines       14699    14699           
=======================================
  Hits        11140    11140           
  Misses       3559     3559

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67c0099...be05a73. Read the comment docs.

@ese ese changed the title [AIRFLOW-2387] Set flask to 0.12.2 [AIRFLOW-2384] Set flask to 0.12.2 Apr 27, 2018
@Fokko
Copy link
Contributor

Fokko commented Apr 28, 2018

Oops, I also fixed this is #3277

@ese ese closed this Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants