Fixes the Kafka provider's max message limit error (#32926) #33321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the issue(apache#32926) where kafka provider returns an error when max messages is not set since it keeps reading and messages left goes into negative.
Makes sure that the kafka provider works when max messages isn't passed into the operator
hussein-awala
approved these changes
Aug 11, 2023
Comment on lines
+164
to
+165
| if not self.read_to_end: | ||
| messages_left -= len(msgs) |
There was a problem hiding this comment.
Discussed and proposed in slack
potiuk
approved these changes
Aug 12, 2023
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
…ache#33321) * Fixes kafka provider failing reading messages Fixes the issue(apache#32926) where kafka provider returns an error when max messages is not set since it keeps reading and messages left goes into negative. Makes sure that the kafka provider works when max messages isn't passed into the operator
98 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kafka provider ConsumeFromTopicOperator throws
an error when max_messages is not set and there exist
more that a 1000 (Default value of max messages) messages
closes: #32926
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.