Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos (double words and it's/its) #33623

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Fix typos (double words and it's/its) #33623

merged 2 commits into from
Aug 23, 2023

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Aug 22, 2023

No description provided.

@boring-cyborg boring-cyborg bot added area:CLI area:dev-tools area:production-image Production image improvements and fixes area:providers area:Scheduler including HA (high availability) scheduler area:Triggerer provider:amazon-aws AWS/Amazon - related issues provider:apache-kafka provider:apache-hdfs provider:cncf-kubernetes Kubernetes provider related issues provider:common-sql provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues labels Aug 22, 2023
hussein-awala
hussein-awala approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@potiuk
Copy link
Member

potiuk commented Aug 22, 2023

Some static checks to solve though :)

BTW. Are you aware of breeze static-checks --only-my-changes @eumiro ?

@eumiro
Copy link
Contributor Author

eumiro commented Aug 22, 2023

@potiuk I'm using pre-commit already, but in this case I was confused with a change that actually automatically generates a .ts file with double words. Reverted that change now.

@potiuk
Copy link
Member

potiuk commented Aug 22, 2023 •
edited
Loading

@potiuk I'm using pre-commit already, but in this case I was confused with a change that actually automatically generates a .ts file with double words. Reverted that change now.

Yeah. We sometimes have some magic stuff going on in the background. But hopefully the amount of magic does not exceed the amount of engineering we have :D

@uranusjr uranusjr merged commit a54c242 into apache:main Aug 23, 2023
63 of 64 checks passed
@eumiro eumiro deleted the typos branch August 23, 2023 04:15
ephraimbuddy pushed a commit that referenced this pull request Sep 3, 2023
@eumiro @ephraimbuddy
Fix typos (double words and it's/its) (#33623)
590412b 
(cherry picked from commit a54c242)
@ephraimbuddy ephraimbuddy mentioned this pull request Sep 4, 2023
Closed
97 tasks
@ephraimbuddy ephraimbuddy added the type:doc-only Changelog: Doc Only label Oct 2, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.7.2 milestone Oct 2, 2023
@eladkal eladkal mentioned this pull request Oct 13, 2023
Closed
98 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@hussein-awala hussein-awala hussein-awala approved these changes

@jedcunningham jedcunningham jedcunningham approved these changes

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@dstandish dstandish Awaiting requested review from dstandish dstandish is a code owner

@kaxil kaxil Awaiting requested review from kaxil kaxil is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@eladkal eladkal Awaiting requested review from eladkal eladkal is a code owner

@o-nikolas o-nikolas Awaiting requested review from o-nikolas o-nikolas is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

Assignees
No one assigned
Labels
area:CLI area:dev-tools area:production-image Production image improvements and fixes area:providers area:Scheduler including HA (high availability) scheduler area:Triggerer provider:amazon-aws AWS/Amazon - related issues provider:apache-hdfs provider:apache-kafka provider:cncf-kubernetes Kubernetes provider related issues provider:common-sql provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues type:doc-only Changelog: Doc Only
Projects
None yet
Milestone
Airflow 2.7.2
Development

Successfully merging this pull request may close these issues.
6 participants
@eumiro @potiuk @hussein-awala @jedcunningham @uranusjr @ephraimbuddy