Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a deprecated option from BigQueryHook.get_pandas_df #33819

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

RyuSA
Copy link
Contributor

@RyuSA RyuSA commented Aug 28, 2023

Why?

I found the method BigQueryHook.get_pandas_df threw a warning message.

/opt/python3.8/lib/python3.8/site-packages/airflow/providers/google/cloud/hooks/bigquery.py:269: FutureWarning: verbose is deprecated and will be removed in a future version. Set logging level in order to vary verbosity

BigQueryHook.get_pandas_df uses pandas_gbq.read_gbq to query BigQuery and convert rows into Frames. Now pandas_gbq.read_gbq throws the warning message if verbose is not None.

Also the version of pandas_gbq in Airflow GCP provider is latest. The project may fail when pandas_gbq removes the parameter verbose.

Any concerns?

Currently pandas_gbq.read_gbq seems not to handle the parameter. 👀 I believe this removal does not affect future releases.
https://github.com/googleapis/python-bigquery-pandas/blob/v0.19.2/pandas_gbq/gbq.py#L731


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

`verbose` will be removed. (pandas_gbq.read_gbq)
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Aug 28, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 28, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Aug 28, 2023

Pending tests passing.

@hussein-awala
Copy link
Member

You need to update the unit tests

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good +1
Can you update the unit tests?

@RyuSA
Copy link
Contributor Author

RyuSA commented Aug 29, 2023

@potiuk @hussein-awala @amoghrajesh Thank you for taking a look.👍 I have added some changes to pass the CI.

@eladkal eladkal merged commit 3b86842 into apache:main Aug 31, 2023
42 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 31, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants