-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove a deprecated option from BigQueryHook.get_pandas_df
#33819
Conversation
`verbose` will be removed. (pandas_gbq.read_gbq)
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Pending tests passing. |
You need to update the unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good +1
Can you update the unit tests?
change the mock param.
@potiuk @hussein-awala @amoghrajesh Thank you for taking a look.👍 I have added some changes to pass the CI. |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Why?
I found the method
BigQueryHook.get_pandas_df
threw a warning message.BigQueryHook.get_pandas_df
usespandas_gbq.read_gbq
to query BigQuery and convert rows into Frames. Nowpandas_gbq.read_gbq
throws the warning message ifverbose
is not None.Also the version of
pandas_gbq
in Airflow GCP provider islatest
. The project may fail whenpandas_gbq
removes the parameterverbose
.Any concerns?
Currently
pandas_gbq.read_gbq
seems not to handle the parameter. 👀 I believe this removal does not affect future releases.https://github.com/googleapis/python-bigquery-pandas/blob/v0.19.2/pandas_gbq/gbq.py#L731
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.