Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DefaultAzureCredential support to AzureContainerRegistryHook #33825

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Aug 28, 2023


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Lee-W Lee-W force-pushed the add-DefaultAzureCredential-support-to-AzureContainerRegistryHook branch 2 times, most recently from d241076 to d119b6a Compare August 29, 2023 02:22
@Lee-W Lee-W force-pushed the add-DefaultAzureCredential-support-to-AzureContainerRegistryHook branch from 5719f80 to 5a6056d Compare August 29, 2023 08:34
@eladkal eladkal changed the title feat(providers/microsoft): add DefaultAzureCredential support to AzureContainerRegistryHook Add DefaultAzureCredential support to AzureContainerRegistryHook Aug 29, 2023
@Lee-W
Copy link
Member Author

Lee-W commented Aug 29, 2023

The static check seems to be canceled again.

@potiuk
Copy link
Member

potiuk commented Aug 29, 2023

The static check seems to be canceled again.

Seems like it took 12 minutes to just "start" installing the environment for mypy checks. So this is likely something flaky/environmental:

Tue, 29 Aug 2023 09:18:29 GMT
[INFO] This may take a few minutes...
Tue, 29 Aug 2023 09:30:52 GMT
[INFO] Installing environment for https://github.com/Lucas-C/pre-commit-hooks.

This takes usually 20 seconds or so on public runners

Tue, 29 Aug 2023 08:59:55 GMT
[INFO] Installing environment for https://github.com/thlorenz/doctoc.git.
Tue, 29 Aug 2023 08:59:55 GMT
[INFO] Once installed this environment will be reused.
Tue, 29 Aug 2023 08:59:55 GMT
[INFO] This may take a few minutes...
Tue, 29 Aug 2023 09:00:15 GMT
[INFO] Installing environment for https://github.com/Lucas-C/pre-commit-hooks.

@potiuk
Copy link
Member

potiuk commented Aug 29, 2023

Right - this is a "Real" problem now you see.

@Lee-W Lee-W force-pushed the add-DefaultAzureCredential-support-to-AzureContainerRegistryHook branch from 5a6056d to 6601ec0 Compare August 29, 2023 16:02
@Lee-W Lee-W force-pushed the add-DefaultAzureCredential-support-to-AzureContainerRegistryHook branch from 6601ec0 to 393d24f Compare August 30, 2023 00:10
@Lee-W Lee-W force-pushed the add-DefaultAzureCredential-support-to-AzureContainerRegistryHook branch from 393d24f to 2e74f9a Compare August 30, 2023 02:59
@Lee-W
Copy link
Member Author

Lee-W commented Aug 30, 2023

Right - this is a "Real" problem now you see.

Got it. Just get it fixed. Thanks!

@pankajastro pankajastro merged commit 539797f into apache:main Aug 30, 2023
64 checks passed
@pankajastro pankajastro deleted the add-DefaultAzureCredential-support-to-AzureContainerRegistryHook branch August 30, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants