-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DefaultAzureCredential support to AzureContainerRegistryHook #33825
Merged
pankajastro
merged 3 commits into
apache:main
from
astronomer:add-DefaultAzureCredential-support-to-AzureContainerRegistryHook
Aug 30, 2023
Merged
Add DefaultAzureCredential support to AzureContainerRegistryHook #33825
pankajastro
merged 3 commits into
apache:main
from
astronomer:add-DefaultAzureCredential-support-to-AzureContainerRegistryHook
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
Azure-related issues
labels
Aug 28, 2023
Taragolis
reviewed
Aug 28, 2023
Lee-W
force-pushed
the
add-DefaultAzureCredential-support-to-AzureContainerRegistryHook
branch
2 times, most recently
from
August 29, 2023 02:22
d241076
to
d119b6a
Compare
pankajastro
approved these changes
Aug 29, 2023
Lee-W
force-pushed
the
add-DefaultAzureCredential-support-to-AzureContainerRegistryHook
branch
from
August 29, 2023 08:34
5719f80
to
5a6056d
Compare
eladkal
reviewed
Aug 29, 2023
eladkal
changed the title
feat(providers/microsoft): add DefaultAzureCredential support to AzureContainerRegistryHook
Add DefaultAzureCredential support to AzureContainerRegistryHook
Aug 29, 2023
The static check seems to be canceled again. |
Seems like it took 12 minutes to just "start" installing the environment for mypy checks. So this is likely something flaky/environmental:
|
Right - this is a "Real" problem now you see. |
Lee-W
force-pushed
the
add-DefaultAzureCredential-support-to-AzureContainerRegistryHook
branch
from
August 29, 2023 16:02
5a6056d
to
6601ec0
Compare
Lee-W
force-pushed
the
add-DefaultAzureCredential-support-to-AzureContainerRegistryHook
branch
from
August 30, 2023 00:10
6601ec0
to
393d24f
Compare
… Container Registry connection
Lee-W
force-pushed
the
add-DefaultAzureCredential-support-to-AzureContainerRegistryHook
branch
from
August 30, 2023 02:59
393d24f
to
2e74f9a
Compare
Got it. Just get it fixed. Thanks! |
pankajastro
deleted the
add-DefaultAzureCredential-support-to-AzureContainerRegistryHook
branch
August 30, 2023 09:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.