Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aws.session_factory part of Amazon provider configuration documentation #33960

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

Taragolis
Copy link
Contributor

Add [aws] session_factory part of AWS Documentation. This configuration option added in #21778 and 3.1.1 version of provider.

This PR doesn't add it in global configuration reference, better add after documentation to Amazon Provider updated, so we do not have missing link in documentation


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Taragolis Taragolis changed the title Make aws.session_factory part of Amazon provider configuration Make aws.session_factory part of Amazon provider configuration documentation Aug 31, 2023
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me but since I am not an english native speaker I am not the best person to review documentation related changes. @o-nikolas if you have a bit of time maybe?

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

airflow/providers/amazon/provider.yaml Outdated Show resolved Hide resolved
airflow/providers/amazon/provider.yaml Outdated Show resolved Hide resolved
airflow/providers/amazon/provider.yaml Outdated Show resolved Hide resolved
@Taragolis
Copy link
Contributor Author

Taragolis commented Sep 1, 2023

Converted to draft, for prevent merge it before #34011 Done

@Taragolis Taragolis marked this pull request as ready for review September 1, 2023 15:03
@vincbeck vincbeck merged commit 6eaa69e into apache:main Sep 1, 2023
42 checks passed
@Taragolis Taragolis deleted the aws-configuration branch September 1, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants