Move the try outside the loop when this is possible in kubernetes provider #33977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Lee-W
reviewed
Sep 1, 2023
| @@ -354,8 +355,8 @@ def sync(self) -> None: | |||
| self.kube_scheduler.sync() | |||
|
|
|||
| last_resource_version: dict[str, str] = defaultdict(lambda: "0") | |||
| while True: | |||
| try: | |||
| with contextlib.suppress(Empty): | |||
There was a problem hiding this comment.
Will it break when Empty is raised as it used to be or just suppress it?
There was a problem hiding this comment.
Empty should be raised by queue.get_nowait(), so previously this would be caught by the exception block to break the loop. Now Empty would be raised and break out of the loop, and then suppressed by this context manager. The end result should be the same.
uranusjr
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #33975
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.