openlineage: fix import in get_custom_facets
#34122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
approved these changes
Sep 5, 2023
| @@ -33,7 +33,7 @@ class AirflowMappedTaskRunFacet(BaseFacet): | |||
| @classmethod | |||
| def from_task_instance(cls, task_instance): | |||
| task = task_instance.task | |||
| from airflow.providers.openlineage.utils import get_operator_class | |||
| from airflow.providers.openlineage.utils.utils import get_operator_class | |||
There was a problem hiding this comment.
Any suggestion how to improve that? :)
There was a problem hiding this comment.
I don't think we should change that now or at all.
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
JDarDagran
force-pushed
the
openlineage/fix-custom-facet
branch
from
26594a1
to
fe75d8c
Compare
mobuchowski
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes broken import in
get_custom_facetsand adds test for it.