Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used cached property for hook in SparkKubernetesOperator #34130

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

vijay-jangir
Copy link
Contributor


Airflow Best practice recommends no top-level code. Constructors should be as simple as possible. Currently, this operator directly builds a KubernetesHook object in its construction which has to make calls to db every time the dag is rendered:

This also doesn't allow for templating of kubernetes_conn_id as brought up in Airflow Slack

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 6, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@vijay-jangir
Copy link
Contributor Author

There's a similar PR #34106 for sensor, but operator also has the same issue, hence this PR.
#34106

@vijay-jangir
Copy link
Contributor Author

Updated existing test case, which expected kubernetesHook to be called once. As the call has been moved out of constructor, it will not be called when object is created.
Added another test which checks for the same once the property is first called.

@vijay-jangir
Copy link
Contributor Author

rebased with main and squashed commits.

@josh-fell josh-fell merged commit 1005501 into apache:main Sep 6, 2023
47 checks passed
@vijay-jangir vijay-jangir deleted the sparkkubernetes_operator branch September 7, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants