Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate get_hook method in DockerOperator #34432

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Deprecate get_hook method in DockerOperator #34432

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4294b51
Deprecate get_hook method in DockerOperator
hussein-awala Sep 16, 2023
02fa10e
use AirflowProviderDeprecationWarning
hussein-awala Sep 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions airflow/providers/docker/operators/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
from tempfile import TemporaryDirectory
from typing import TYPE_CHECKING, Iterable, Sequence

from deprecated.classic import deprecated
from docker.constants import DEFAULT_TIMEOUT_SECONDS
from docker.errors import APIError
from docker.types import LogConfig, Mount, Ulimit
Expand Down Expand Up @@ -328,6 +329,7 @@ def hook(self) -> DockerHook:
timeout=self.timeout,
)

@deprecated(reason="use `hook` property instead.", category=AirflowProviderDeprecationWarning)
def get_hook(self) -> DockerHook:
"""Create and return an DockerHook (cached)."""
return self.hook
Expand Down