Use aiohttp.BasicAuth instead of HTTPBasicAuth for aiohttp session in databricks hook #34590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
approved these changes
Sep 25, 2023
phanikumv
approved these changes
Sep 25, 2023
|
Hi @hussein-awala, thanks for the fix of #34450 |
98 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #34450
Databricks hook uses aiohttp client session for async methods, but in the method
_a_get_sp_token, we useHTTPBasicAuthinstance to provide basic authentication credentials which is not compatible with aiohttp sessions. This PR fixes the issue by providing the credentials usingaiohttp.BasicAuthinstance as we do in the other methods.