Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve intelligibility of end_of_log determination #34788

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Improve intelligibility of end_of_log determination #34788

merged 1 commit into from
Oct 5, 2023

Conversation

dstandish
Copy link
Contributor

The loop var logs shadowed the outer var. Confusing. use of any makes it clearer what's happening

@jedcunningham jedcunningham merged commit a1a2352 into apache:main Oct 5, 2023
43 checks passed
@jedcunningham jedcunningham deleted the es-handler-make-code-less-confusing branch October 5, 2023 22:17
@eladkal eladkal mentioned this pull request Oct 13, 2023
Closed
98 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedcunningham jedcunningham jedcunningham approved these changes

Assignees
No one assigned
Labels
area:logging area:providers provider:elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstandish @jedcunningham