Extend hooks arguments into AwsBaseWaiterTrigger
#34884
Conversation
boring-cyborg
bot
added
area:providers
provider:amazon-aws
Taragolis
force-pushed
the
amazon-extend-base-triggerer
branch
from
f8f9a30
to
997495d
Compare
| @pytest.mark.parametrize( | ||
| "botocore_config", | ||
| [ | ||
| pytest.param({"read_timeout": 10, "connect_timeout": 42, "keepalive": True}, id="non-empty-dict"), |
There was a problem hiding this comment.
Do we have such example exposed in the docs?
There was a problem hiding this comment.
Not yet. Let's add it with first migrated Operators.
Lambda it is a good candidate for first migration:
- Just couple Operators/Sensors
- Have deferrable mode
There was a problem hiding this comment.
The idea create similar RST file as https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-amazon/_partials/prerequisite_tasks.rst
Describe generic hook parameters + links to boto3 docs (if required) and include into migrated operators
There was a problem hiding this comment.
I think it's best to create doc for the base class rather than add the example to all/selected operators
There was a problem hiding this comment.
Yeah we could create page for base boto3 based operators.
However I think that we also need to have this kind of documentation into the specific operators pages. Because from auto-API pages users would go to the operator specific page.
There was a problem hiding this comment.
I have a plan create some draft PR during the day, so we could discuss documentation there
--------- Co-authored-by: Vincent Beck <vincbeck@amazon.com>
Follow-up: #34784
Optionally serialise
verifyandbotocore_configparameters inAwsBaseWaiterTrigger^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.