Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-69: Add CLI to Edge Provider #42050

Merged

Conversation

jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Sep 5, 2024

This PR is a split of #41729 and builds on-top of #42046 and #42047 to make review easier.

It only contains the new Edge CLI functions needed of the edge provider package - the CLI is needed to run the worker on the remote site. The first commit is from the other base PRs and if this is merged will go-away on rebase. If you want to see Executor implementation only, please take a look to the second commit only,

Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Small comments, nits and proofreading :)

airflow/providers/edge/cli/edge_command.py Outdated Show resolved Hide resolved
airflow/providers/edge/cli/edge_command.py Outdated Show resolved Hide resolved
airflow/providers/edge/cli/edge_command.py Outdated Show resolved Hide resolved
airflow/providers/edge/cli/edge_command.py Outdated Show resolved Hide resolved
@jscheffl jscheffl force-pushed the feature/aip-69-remote-executor-provider-cli branch from 1ef51d0 to f2a3593 Compare September 24, 2024 20:15
@jscheffl jscheffl merged commit 3390bfb into apache:main Sep 24, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants