-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-4731] Broken get_bucket kwarg in GCS hook #5368
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5368 +/- ##
=======================================
Coverage 79.03% 79.03%
=======================================
Files 480 480
Lines 30129 30129
=======================================
Hits 23813 23813
Misses 6316 6316
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5368 +/- ##
==========================================
+ Coverage 79.02% 79.05% +0.03%
==========================================
Files 481 481
Lines 30191 30218 +27
==========================================
+ Hits 23858 23889 +31
+ Misses 6333 6329 -4
Continue to review full report at Codecov.
|
Ugh thanks Google. Could you include a note about this change in our UPDATING.md please (some people may be using the package directly.) |
google-storage-client 1.16 introduced a breaking change where the signature of client.get_bucket changed from (bucket_name) to (bucket_or_name). Calls with named arguments to this method now fail. This commit makes all calls positional to work around this.
Oh - could we safely make the calls positional (as you've done) but leave the version constraint as it is? Then we would reduce the chance of this breaking other code. Or do you think it's better to force the update of the dep? |
The dependency version doesn't need to be forced, if you'd prefer it not be. The tradeoff is tricky - the existing |
I think it's quite OK with bumping up the dependency. I don't see any downside of it, and this is indeed valid point with ~ installing 1.16. |
google-storage-client 1.16 introduced a breaking change where the signature of client.get_bucket changed from (bucket_name) to (bucket_or_name). Calls with named arguments to this method now fail. This commit makes all calls positional to work around this. (cherry picked from commit 201e671)
) google-storage-client 1.16 introduced a breaking change where the signature of client.get_bucket changed from (bucket_name) to (bucket_or_name). Calls with named arguments to this method now fail. This commit makes all calls positional to work around this. (cherry picked from commit 201e671)
) google-storage-client 1.16 introduced a breaking change where the signature of client.get_bucket changed from (bucket_name) to (bucket_or_name). Calls with named arguments to this method now fail. This commit makes all calls positional to work around this. (cherry picked from commit 201e671)
Make sure you have checked all steps below.
Jira
Description
google-storage-client 1.16 introduced a breaking change where the
signature of client.get_bucket changed from (bucket_name) to
(bucket_or_name). Calls with named arguments to this method now fail.
This commit makes all calls positional to work around this.
Upstream change at googleapis/google-cloud-python#7856
Tests
Updated one test in test_gcs_hook
Commits
Documentation
Code Quality
flake8