Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set the correct rpc response type when meet an error #102

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

MrLYC
Copy link
Contributor

@MrLYC MrLYC commented Sep 8, 2022

Go runner always return the request rpc type as response type, according to the protocol, it should return RPCError when meet an error.

@soulbird
Copy link
Contributor

soulbird commented Sep 9, 2022

Let's merge the master branch to run E2E Test.

@codecov-commenter
Copy link

Codecov Report

Merging #102 (71906e7) into master (bd5d11f) will decrease coverage by 1.74%.
The diff coverage is 27.77%.

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   82.38%   80.64%   -1.75%     
==========================================
  Files          14       14              
  Lines         897      899       +2     
==========================================
- Hits          739      725      -14     
- Misses        113      132      +19     
+ Partials       45       42       -3     
Impacted Files Coverage Δ
internal/server/server.go 53.90% <27.77%> (-11.97%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@soulbird soulbird merged commit a3a31cd into apache:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants