Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write response header should not break req #65

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

spacewander
Copy link
Member

Although it won't take effect without calling Write or WriteHeader
for now.

Fix #64.

Although it won't take effect without calling `Write` or `WriteHeader`
for now.

Fix apache#64.
@codecov-commenter
Copy link

Codecov Report

Merging #65 (8037394) into master (195bd64) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   78.88%   78.88%           
=======================================
  Files          11       11           
  Lines         701      701           
=======================================
  Hits          553      553           
  Misses        111      111           
  Partials       37       37           
Impacted Files Coverage Δ
internal/http/response.go 100.00% <100.00%> (ø)
internal/plugin/conf.go 89.04% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 195bd64...8037394. Read the comment docs.

@spacewander spacewander marked this pull request as ready for review February 13, 2022 14:02
@spacewander spacewander merged commit 1a00a4b into apache:master Feb 14, 2022
@spacewander spacewander deleted the fad branch February 14, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request help: The upstream service cannot be invoked after the header is set in the Filter method
3 participants