Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rewrite:RespHeaders and modify the upstream response ers via request implementation #68

Merged
merged 10 commits into from
Mar 8, 2022

Conversation

rampagecong
Copy link
Contributor

This submission is modified as follows:

1.Add respHdr and RespHeader method to Request struct.

2.The Request FetchChanges method is modified.

3.Add and modify some test cases

This is refer to #67

@spacewander
Copy link
Member

Sorry for my delay. Could you make the CI pass?

Copy link
Member

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update go.mod to use github.com/api7/ext-plugin-proto v0.4.0

@rampagecong
Copy link
Contributor Author

OK

@spacewander
Copy link
Member

Need to resolve conflicts

pkg/http/http.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022

Codecov Report

Merging #68 (24381ca) into master (ade2e90) will decrease coverage by 2.19%.
The diff coverage is 96.15%.

❗ Current head 24381ca differs from pull request most recent head 95a790f. Consider uploading reports for the commit 95a790f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   80.60%   78.41%   -2.20%     
==========================================
  Files          11       11              
  Lines         722      746      +24     
==========================================
+ Hits          582      585       +3     
- Misses        102      122      +20     
- Partials       38       39       +1     
Impacted Files Coverage Δ
internal/http/request.go 93.49% <96.15%> (+0.70%) ⬆️
internal/server/server.go 50.40% <0.00%> (-17.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ade2e90...95a790f. Read the comment docs.

@rampagecong
Copy link
Contributor Author

Hello,Please run CI again.
@spacewander

@shuaijinchao shuaijinchao merged commit 98ed96a into apache:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants