Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add e2e test framework #72

Merged
merged 21 commits into from
Mar 23, 2022
Merged

Conversation

Chever-John
Copy link
Contributor

add e2e test framework

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #72 (ebf4a9f) into master (8fdac12) will decrease coverage by 1.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   80.84%   79.49%   -1.36%     
==========================================
  Files          11       11              
  Lines         710      746      +36     
==========================================
+ Hits          574      593      +19     
- Misses        100      114      +14     
- Partials       36       39       +3     
Impacted Files Coverage Δ
internal/server/server.go 56.91% <0.00%> (-10.57%) ⬇️
internal/http/request.go 93.49% <0.00%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fdac12...ebf4a9f. Read the comment docs.

tests/e2e/plugins/plugins_limit_req_test.go Outdated Show resolved Hide resolved
tests/e2e/plugins/plugins_limit_req_test.go Outdated Show resolved Hide resolved
tests/e2e/plugins/plugins_limit_req_test.go Outdated Show resolved Hide resolved
@shuaijinchao shuaijinchao merged commit dee7fa0 into apache:master Mar 23, 2022

- name: startup runner
run: |
APISIX_LISTEN_ADDRESS=unix:/tmp/runner.sock APISIX_CONF_EXPIRE_TIME=3600 ./go-runner run &
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to let APISIX manage the go-runner, just like in the product environment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will solve it by creating a new PR.

image: mendhak/http-https-echo
environment:
HTTP_PORT: 8888
HTTPS_PORT: 9999
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTTPS port is unused.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear!

Headers: map[string]string{"X-API-KEY": tools.GetAdminToken()},
ExpectStatusRange: httpexpect.Status2xx,
}),
table.Entry("Test if limit-req plugin work.", tools.HttpTestCase{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The limit-req test doesn't test the limit req behavior...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants