Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DefaultPlugin #92

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Conversation

soulbird
Copy link
Contributor

Add DefaultPlugin so that we don't need to reimplement all the methods.

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #92 (a8ec02b) into master (d283ba2) will decrease coverage by 1.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   82.01%   80.04%   -1.98%     
==========================================
  Files          14       14              
  Lines         901      897       -4     
==========================================
- Hits          739      718      -21     
- Misses        117      133      +16     
- Partials       45       46       +1     
Impacted Files Coverage Δ
cmd/go-runner/plugins/fault_injection.go 61.29% <ø> (+1.91%) ⬆️
cmd/go-runner/plugins/limit_req.go 81.81% <ø> (+3.55%) ⬆️
cmd/go-runner/plugins/response_rewrite.go 82.60% <ø> (+3.44%) ⬆️
cmd/go-runner/plugins/say.go 77.77% <ø> (+4.09%) ⬆️
internal/server/server.go 49.20% <0.00%> (-16.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d283ba2...a8ec02b. Read the comment docs.

@soulbird soulbird marked this pull request as ready for review June 21, 2022 09:58
pkg/plugin/plugin.go Outdated Show resolved Hide resolved
@spacewander spacewander merged commit ee55902 into apache:master Jun 22, 2022
MrLYC pushed a commit to MrLYC/apisix-go-plugin-runner that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants