feat(ops): check process running with posix.signal insteadof lsof

apisix/cli/ops.lua

@@ -25,6 +25,8 @@ local profile = require("apisix.core.profile")
 local template = require("resty.template")
 local argparse = require("argparse")
 local pl_path = require("pl.path")
+local signal = require("posix.signal")
+local errno = require("posix.errno")
 
 local stderr = io.stderr
 local ipairs = ipairs
@@ -729,15 +731,20 @@ local function start(env, ...)
     local pid = util.read_file(pid_path)
     pid = tonumber(pid)
     if pid then
-        local lsof_cmd = "lsof -p " .. pid
-        local res, err = util.execute_cmd(lsof_cmd)
-        if not (res and res == "") then
-            if not res then
-                print(err)
-            else
-                print("APISIX is running...")
-            end
+        if pid <= 0 then
+            print("invalid pid")
+            return
+        end
+
+        local signone = 0
 
+        local ok, err, err_no = signal.kill(pid, signone)
+        if ok then
+            print("APISIX is running...")
+            return
+        -- no such process
+        elseif err_no ~= errno.ESRCH then
+            print(err)
             return
         end
 

t/cli/test_main.sh

@@ -706,6 +706,26 @@ fi
 ./bin/apisix stop
 echo "pass: ignore stale nginx.pid"
 
+# check operation not permitted
+sudo make run
+out=$(make run || true)
+if ! echo "$out" | grep "Operation not permitted"; then
+    echo "failed: should find operation not permitted"
+    exit 1
+fi
+sudo make stop
+echo "pass: operation not permitted"
+
+# check running when run repeatedly
+out=$(make run; make run || true)
+if ! echo "$out" | grep "APISIX is running"; then
+    echo "failed: should find APISIX running"
+    exit 1
+fi
+
+make stop
+echo "pass: check APISIX running"
+
 # check the keepalive related parameter settings in the upstream
 git checkout conf/config.yaml