fix: redirect http to https but port not change

[jwrookie]

Description

When http redirects to htpps, we use a correct port

Fixes #7011

Checklist

• I have explained the need for this PR and the problem it solves
• I have explained the changes or the new features added to this PR
• I have added tests corresponding to this change
• I have updated the documentation to reflect this change
• I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

[spacewander]

We should use a structure like this:

redirect:
    https_port: ...

and comment it out as nobody wants to be redirected to 8443 by default.

[jwrookie]

done

[spacewander]

There is a wrapper to get the attribute of a plugin:

apisix/apisix/plugins/prometheus.lua

Line 58 in 6ebe027

local attr = plugin.plugin_attr(plugin_name)

We need to use it instead.

[jwrookie]

done

[spacewander]

Let's add two more test:

1. use listen_port
2. use listen and get port in the array

[jwrookie]

Done

[spacewander]

redirect_https_port should be updated

[jwrookie]

Done

[spacewander]

ditto

[jwrookie]

done

[spacewander]

ditto

[jwrookie]

done

[soulbird]

Personally, I feel that this code is too inelegant. Suggest:

local function get_port(attr)
    local port
    if attr then
        port = attr.https.port
    end

    if port then
        return port
    end

    local local_conf = core.config.local_conf()
    local ssl = core.table.try_read_attr(local_conf, "apisix", "ssl")
    if not ssl or ssl["enable"] then
        return port
    end

    port = ssl["listen_port"]
    if port then
        return port
    end

    local ports = ssl["listen"]
    if ports and #ports > 0 then
        local idx = math_random(1, #ports)
        port = ports[idx]
        if type(port) == "table" then
            port = port.port
        end
    end

    return port
end

local ret_port = get_port(attr)

[jwrookie]

done

[tokers]

Where did you define the variable plugin_name?

[jwrookie]

here:

apisix/apisix/plugins/redirect.lua

Lines 65 to 67 in 6ebe027

	local plugin_name = "redirect"

[jwrookie]

Was defined before :)

[spacewander]

Let's merge master to make CI pass.