Skip to content

Commit

Permalink
MINOR: [C++][Acero] Replace acero-specific append avx2 cmake macro wi…
Browse files Browse the repository at this point in the history
…th generic one (#44240)

### Rationale for this change

Macro `append_acero_runtime_avx2_src` is duplicated with generic `append_runtime_avx2_src`.

### What changes are included in this PR?

Remove `append_acero_runtime_avx2_src` and replace it with `append_runtime_avx2_src`.

### Are these changes tested?

CI should be enough.

### Are there any user-facing changes?

None.

Authored-by: Ruoxi Sun <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
  • Loading branch information
zanmato1984 committed Sep 26, 2024
1 parent dcf0d8c commit a576421
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions cpp/src/arrow/acero/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,6 @@ add_custom_target(arrow_acero)

arrow_install_all_headers("arrow/acero")

macro(append_acero_runtime_avx2_src SRC)
if(ARROW_HAVE_RUNTIME_AVX2)
list(APPEND ARROW_ACERO_SRCS ${SRC})
set_source_files_properties(${SRC} PROPERTIES SKIP_PRECOMPILE_HEADERS ON)
set_source_files_properties(${SRC} PROPERTIES COMPILE_FLAGS ${ARROW_AVX2_FLAG})
endif()
endmacro()

set(ARROW_ACERO_SRCS
accumulation_queue.cc
scalar_aggregate_node.cc
Expand Down Expand Up @@ -58,8 +50,8 @@ set(ARROW_ACERO_SRCS
union_node.cc
util.cc)

append_acero_runtime_avx2_src(bloom_filter_avx2.cc)
append_acero_runtime_avx2_src(swiss_join_avx2.cc)
append_runtime_avx2_src(ARROW_ACERO_SRCS bloom_filter_avx2.cc)
append_runtime_avx2_src(ARROW_ACERO_SRCS swiss_join_avx2.cc)

set(ARROW_ACERO_SHARED_LINK_LIBS)
set(ARROW_ACERO_SHARED_PRIVATE_LINK_LIBS)
Expand Down

0 comments on commit a576421

Please sign in to comment.