Skip to content

Commit

Permalink
Review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
rok committed Sep 26, 2024
1 parent 586bd5b commit ea75cdb
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
6 changes: 0 additions & 6 deletions python/pyarrow/tests/parquet/test_data_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -523,9 +523,3 @@ def test_json_extension_type(storage_type):
table = pa.table([arr], names=["ext"])

_simple_table_roundtrip(table)

for storage_type in (pa.int32(), pa.large_binary(), pa.float32()):
with pytest.raises(
pa.ArrowInvalid,
match="Invalid storage type for JsonExtensionType: " + str(storage_type)):
pa.json_(storage_type)
7 changes: 7 additions & 0 deletions python/pyarrow/tests/test_extension_type.py
Original file line number Diff line number Diff line change
Expand Up @@ -1973,3 +1973,10 @@ def test_json(storage_type, pickle_module):
# cast extension type -> storage type
inner = array.cast(storage_type)
assert inner == storage

for storage_type in (pa.int32(), pa.large_binary(), pa.float32()):
with pytest.raises(
pa.ArrowInvalid,
match="Invalid storage type for JsonExtensionType: " +
str(storage_type)):
pa.json_(storage_type)

0 comments on commit ea75cdb

Please sign in to comment.