Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-37543: [C#][DRAFT] Implement support for Apache Acero #37544

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

davesearle
Copy link

@davesearle davesearle commented Sep 4, 2023

Add support for Apache Acero.

Rationale for this change

I'm currently working on a project (in C#) that requires the ability to transform Arrow streams. The functionality provided by Acero is a good fit, however the current C# library does not support it. This PR looks to address that short coming. Given the potential size of these changes, I've opened a draft PR in case anyone else is looking to add support for Acero.

What changes are included in this PR?

  • Implement support for the following source nodes:
    • record_batch_source
    • record_batch_reader_source
  • Implement support for the following compute nodes:
    • filter
    • project
  • Implement support for the following arrangement nodes:
    • hash_join
    • union
  • Implement support for the following sink nodes:
    • sink

Are these changes tested?

Yes

Are there any user-facing changes?

@davesearle davesearle marked this pull request as draft September 4, 2023 14:11
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

⚠️ GitHub issue #37543 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member

kou commented Sep 4, 2023

How about using small PRs instead of one large PR to support Acero?
For example, one PR for record_batch_source, one PR for filter and so on.
Small PRs are easier to review than one large PR.

Implement project node. Improve error handling and general tidy up of code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C#] Implement support for Apache Acero
2 participants